Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: lenra_common dependancy #40

Merged
merged 2 commits into from
Aug 29, 2023
Merged

refactor!: lenra_common dependancy #40

merged 2 commits into from
Aug 29, 2023

Conversation

Nesqwik
Copy link
Member

@Nesqwik Nesqwik commented Aug 29, 2023

Description of the changes

Remove lenra_common from query parser.
The error management is a bit simpler, we simply need to restore the error where we use this library, catch the {:error, :invalid_query} tuple and return the BusinessError instead.

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

Copy link
Member

@taorepoara taorepoara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK

@taorepoara taorepoara merged commit 28efc12 into beta Aug 29, 2023
3 checks passed
@taorepoara taorepoara deleted the remove_lenra_common branch August 29, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants